#11530: Conversion of finite field elements to PARI mangles Mod
------------------------------+---------------------------------------------
   Reporter:  rbeezer         |          Owner:  AlexGhitza                     
         
       Type:  defect          |         Status:  needs_review                   
         
   Priority:  major           |      Milestone:  sage-4.7.1                     
         
  Component:  algebra         |       Keywords:  _pari_init_, variable name, 
finite field
Work_issues:                  |       Upstream:  N/A                            
         
   Reviewer:  Jeroen Demeyer  |         Author:  Simon King                     
         
     Merged:                  |   Dependencies:                                 
         
------------------------------+---------------------------------------------

Comment(by rbeezer):

 v2 patch is a tweak of Simon's nice patch.  Passes all tests in
 sage/rings.  I think this will allow totally removing the two versions of
 {{{_finite_field_ext_pari_modulus_as_str()}}}.  I am going to test the
 removal with a test of the full Sage library.

 Without search and replace, we get a 2x speedup.  I have not posted my
 search/replace patch since it seems useless now.

 Timings, all in microseconds, of the two commands below.

 {{{
 sage: F.<a>=GF(3^5)
 sage: a._pari_init_()
 sage: a._pari_init_('b')

                         var=None       var='b'
 4.7 status quo            779            780
 Rob search/replace        782            787
 Simon                     781            381
 Simon + Rob (v2)          369            381
 }}}

 So it appears better coding will get us speed improvements.  Imagine that!

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11530#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to