#11422: modular subgroups
------------------------------+---------------------------------------------
   Reporter:  vdelecroix      |          Owner:  vdelecroix                     
             
       Type:  enhancement     |         Status:  positive_review                
             
   Priority:  major           |      Milestone:  sage-4.7.2                     
             
  Component:  modular forms   |       Keywords:  group, arithmetic, linear 
group, sl, modular
Work_issues:                  |       Upstream:  N/A                            
             
   Reviewer:  David Loeffler  |         Author:  Vincent Delecroix              
             
     Merged:                  |   Dependencies:  #10334, #10335                 
             
------------------------------+---------------------------------------------
Changes (by vdelecroix):

  * status:  needs_review => positive_review
  * work_issues:  to_even_subgroup problem =>


Comment:

 Replying to [comment:17 davidloeffler]:
 > Here's a patch. The problem was the use of a python set type: you can
 certainly enumerate sets, but you shouldn't expect the enumeration order
 to be consistent! I changed the code slightly to use lists, combining two
 loops into one.
 >
 > Vincent: if you're happy with my change, you can restore the positive
 review.

 Thanks for debugging (it seems that you're using the code... cool!).

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11422#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to