#11685: Pari finite field extension: element created by list not recognised as
zero
----------------------------------------+-----------------------------------
Reporter: johanbosman | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7.2
Component: algebra | Keywords: finite fields, pari
Work_issues: | Upstream: N/A
Reviewer: Simon King, Johan Bosman | Author: Johan Bosman, Jeroen
Demeyer
Merged: | Dependencies:
----------------------------------------+-----------------------------------
Changes (by jdemeyer):
* status: needs_info => needs_review
Comment:
Replying to [comment:31 SimonKing]:
> I tend to a positive review as well.
>
> However, I have one question (thus "needs info"): Why did you remove the
`if not check: ...` section? If one knows that the input is sane then it
is very common to use `check=False` in order to save time.
1) That option and the code was completely undocumented and the purpose is
not clear.
2) The logic seems backward: executing more code when ''not'' checking?
3) The ``check`` code changes the functionality of the function, which is
usually not desired. To me checking should be something read-only,
checking for invalid input and throwing exceptions. But not modifying the
input.
4) the ``check`` code is related to the handling of zero inputs which is
anyway handled separately in the code below.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11685#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
