#10453: Problem with old submodule
-----------------------------+----------------------------------------------
Reporter: davidloeffler | Owner: craigcitro
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.7.2
Component: modular forms | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Johan Bosman | Author: David Loeffler
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Changes (by johanbosman):
* status: needs_review => positive_review
* reviewer: => Johan Bosman
Comment:
The code looks sound and is well documented. All long doctests pass. I
played around with it and couldn't produce any false results. I did get
the following while applying the patch:
{{{
applying trac_10453_gamma1_old_submodule.patch
patching file sage/modular/hecke/ambient_module.py
Hunk #10 succeeded at 883 with fuzz 1 (offset 6 lines).
now at: trac_10453_gamma1_old_submodule.patch
}}}
but according to [http://groups.google.com/group/sage-
devel/browse_thread/thread/c5af325e984d8ab4/cb85c8767055af0e?lnk=gst&q=fuzz#cb85c8767055af0e
this discussion], fuzz 1 is okay. Hence: positive review. ;).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10453#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
