#10453: Problem with old submodule
-----------------------------+----------------------------------------------
Reporter: davidloeffler | Owner: craigcitro
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.7.2
Component: modular forms | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Johan Bosman | Author: David Loeffler
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Old description:
> Weird things happen if you try to compute the old submodule of a Gamma1
> modular forms space. E.g.
>
> {{{
> sage: CuspForms(Gamma1(11), 2).old_submodule() # crashes
> }}}
>
> This turns out to be because:
>
> {{{
> sage: ModularForms(Gamma1(11),
> 2).hecke_module_of_level(1).hecke_module_of_level(11)
> Modular Forms space of dimension 2 for Congruence Subgroup Gamma0(11) of
> weight 2 over Rational Field
> }}}
>
> so the degeneracy level-raising map is getting computed for the wrong
> space!
>
> Prerequisite for #11601. (Note that #11601 depends on a bunch of other
> stuff as well, but this ticket is independent of any of the other patches
> in the series.)
New description:
Weird things happen if you try to compute the old submodule of a Gamma1
modular forms space. E.g.
{{{
sage: CuspForms(Gamma1(11), 2).old_submodule() # crashes
}}}
This turns out to be because:
{{{
sage: ModularForms(Gamma1(11),
2).hecke_module_of_level(1).hecke_module_of_level(11)
Modular Forms space of dimension 2 for Congruence Subgroup Gamma0(11) of
weight 2 over Rational Field
}}}
so the degeneracy level-raising map is getting computed for the wrong
space!
Prerequisite for #11601. (Note that #11601 depends on a bunch of other
stuff as well, but this ticket is independent of any of the other patches
in the series.)
----
Apply [attachment:trac_10453_gamma1_old_submodule.patch] to the Sage
library.
--
Comment(by leif):
Replying to [comment:6 johanbosman]:
> I did get the following while applying the patch:
{{{
applying trac_10453_gamma1_old_submodule.patch
patching file sage/modular/hecke/ambient_module.py
Hunk #10 succeeded at 883 with fuzz 1 (offset 6 lines).
now at: trac_10453_gamma1_old_submodule.patch
}}}
> but according to [http://groups.google.com/group/sage-
devel/browse_thread/thread/c5af325e984d8ab4/cb85c8767055af0e?lnk=gst&q=fuzz#cb85c8767055af0e
this discussion], fuzz 1 is okay. Hence: positive review. ;).
In this case, you could re-export the patch and upload the rebased
version.
IMHO one should inspect any fuzz anyway.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10453#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
