#11142: clean up sage/misc/hg.py
-----------------------------------+----------------------------------------
Reporter: jhpalmieri | Owner: jason
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.7.2
Component: misc | Keywords: sd31
Work_issues: | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: John Palmieri
Merged: | Dependencies: #10594
-----------------------------------+----------------------------------------
Comment(by kcrisman):
> * Does `hg_sage.revert()` really just revert all files? I always
needed `options="--all"`, but maybe I don't any more.
Yeah, this does not work.
{{{
sage: hg_sage.revert()
cd "/Users/.../sage-4.7.1/devel/sage" && hg revert
abort: no files or directories specified; use --all to revert the whole
repo
}}}
This is even after the patch and hg upgrade. We definitely need to have
documentation for this. Ideally, we'd even catch it in `hg_sage.revert`
itself. It takes a while to figure out you need {{{options="--all"}}} as
a newbie.
Or we could change the behavior so that it does this.
> * What happens if a user does ''not'' have queues enabled in their
.hgrc but tries to use the queue commands? (My understanding is that
#11121 doesn't really affect this patch/ticket, correct?)
Ok, Keshav, as long as you vouch for this. Changing my hgrc didn't seem to
do anything (the desired behavior), but maybe the repository already had
hg initialized with mq or something...
> * I haven't tried `hg_sage.root` but I assume this was enabled when the
root directory finally got a repository?
Yes. Cool! Now I can edit the README more effectively :)
Current patch (with R, not FRX) does indeed clear the screen after a short
view in the pager is quit. I thought this was not the current behavior,
but apparently I get that with my 4.7 and 4.4.4 installs as well, so I'm a
bit confused.
Otherwise we just need to test a lot of this stuff, but it looks good.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11142#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
