#11142: clean up sage/misc/hg.py
-----------------------------------+----------------------------------------
   Reporter:  jhpalmieri           |          Owner:  jason        
       Type:  enhancement          |         Status:  needs_review 
   Priority:  minor                |      Milestone:  sage-4.7.2   
  Component:  misc                 |       Keywords:  sd31         
Work_issues:                       |       Upstream:  N/A          
   Reviewer:  Karl-Dieter Crisman  |         Author:  John Palmieri
     Merged:                       |   Dependencies:  #10594       
-----------------------------------+----------------------------------------

Comment(by kcrisman):

 There are a bunch of things that didn't seem to look so good in the
 documentation.  Then I went ahead and made various other minor changes in
 a reviewer patch.   You can pick and choose, or just say positive review.
 I tried to actually build the changes, but my Sage is funny sometimes and
 doesn't recognize changed files for the docbuild.

 The only ones I would insist on are
 {{{
 -        To see the changes in this file since revision 10000:
 +        To see the changes in this file since revision 10000::
 }}}
 and the stuff about emailing William with a bundle, which is totally
 outdated in several ways.

 I also wonder if you wanted to use `::` for the various options for the hg
 commands. It looks nice, but in other places (like plot documentation) we
 just use the Sphinx subitem syntax, I think, so maybe we shouldn't make
 those look like examples.  I am okay with either one, just wanted to ask
 about this.

 Positive review on the updates and patch, though.  I'm already using it!

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11142#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to