#9138: Categories for all rings
--------------------------------------------+-------------------------------
Reporter: jbandlow | Owner: nthiery
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.7.2
Component: categories | Keywords: introspection,
categories for rings
Work_issues: fix doctests errors in pbory | Upstream: N/A
Reviewer: | Author: Simon King
Merged: | Dependencies: sage-4.7,
#11268, #11139, #9976, #9944, #11269, #11316
--------------------------------------------+-------------------------------
Changes (by mderickx):
* status: needs_review => needs_work
* work_issues: Fix doctest errors created by the second patch => fix
doctests errors in pbory
Comment:
I tested against sage-4.7.2.alpha1 . I didn't add any dependancys because
their descriptions all say they are merged in that version already. Almost
all test pass except some tests in pbori.pyx .
{{{
mderickx@sage:/mnt/usb1/scratch/mderickx/sage-4.7.2.alpha1/devel/sage$
../../sage -t --long sage/rings/polynomial/pbori.pyx
sage -t --long "devel/sage-main/sage/rings/polynomial/pbori.pyx"
**********************************************************************
File "/mnt/usb1/scratch/mderickx/sage-4.7.2.alpha1/devel/sage-
main/sage/rings/polynomial/pbori.pyx", line 843:
sage: P(p)
Exception raised:
Traceback (most recent call last):
File "/home/mderickx/.sage/tmp/ncadoctest.py", line 1231, in
run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/home/mderickx/.sage/tmp/sagedoctest.py", line 38, in
run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/home/mderickx/.sage/tmp/ncadoctest.py", line 1172, in
run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_10[23]>", line 1, in <module>
P(p)###line 843:
sage: P(p)
File "parent.pyx", line 945, in
sage.structure.parent.Parent.__call__ (sage/structure/parent.c:7108)
File "coerce_maps.pyx", line 82, in
sage.structure.coerce_maps.DefaultConvertMap_unique._call_
(sage/structure/coerce_maps.c:3256)
File "coerce_maps.pyx", line 77, in
sage.structure.coerce_maps.DefaultConvertMap_unique._call_
(sage/structure/coerce_maps.c:3159)
File "pbori.pyx", line 896, in
sage.rings.polynomial.pbori.BooleanPolynomialRing._element_constructor_
(sage/rings/polynomial/pbori.cpp:8488)
IndexError: list index out of range
**********************************************************************
File "/mnt/usb1/scratch/mderickx/sage-4.7.2.alpha1/devel/sage-
main/sage/rings/polynomial/pbori.pyx", line 563:
sage: ZZ['a'].gen() + c
Exception raised:
Traceback (most recent call last):
File "/home/mderickx/.sage/tmp/ncadoctest.py", line 1231, in
run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/home/mderickx/.sage/tmp/sagedoctest.py", line 38, in
run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/home/mderickx/.sage/tmp/ncadoctest.py", line 1172, in
run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_8[16]>", line 1, in <module>
ZZ['a'].gen() + c###line 563:
sage: ZZ['a'].gen() + c
File "element.pyx", line 1309, in
sage.structure.element.RingElement.__add__
(sage/structure/element.c:11532)
File "coerce.pyx", line 713, in
sage.structure.coerce.CoercionModel_cache_maps.bin_op
(sage/structure/coerce.c:6420)
File "coerce.pyx", line 827, in
sage.structure.coerce.CoercionModel_cache_maps.canonical_coercion
(sage/structure/coerce.c:7682)
File "coerce_maps.pyx", line 82, in
sage.structure.coerce_maps.DefaultConvertMap_unique._call_
(sage/structure/coerce_maps.c:3256)
File "coerce_maps.pyx", line 77, in
sage.structure.coerce_maps.DefaultConvertMap_unique._call_
(sage/structure/coerce_maps.c:3159)
File "pbori.pyx", line 896, in
sage.rings.polynomial.pbori.BooleanPolynomialRing._element_constructor_
(sage/rings/polynomial/pbori.cpp:8488)
IndexError: list index out of range
**********************************************************************
2 items had failures:
1 of 25 in __main__.example_10
1 of 18 in __main__.example_8
***Test Failed*** 2 failures.
For whitespace errors, see the file
/home/mderickx/.sage//tmp/.doctest_pbori.py
[6.1 s]
----------------------------------------------------------------------
The following tests failed:
sage -t --long "devel/sage-main/sage/rings/polynomial/pbori.pyx"
Total time for all tests: 6.1 seconds
}}}
A little sanity check that #11316 was really merged in 4.7.2.alpha1
{{{
mderickx@sage:/mnt/usb1/scratch/mderickx/sage-4.7.2.alpha1/devel/sage$
../../sage -hg log sage/rings/polynomial/pbori.pyx |head -n 20
changeset: 15995:f3369d315c96
tag: qtip
tag: tip
tag: trac9138_categories_for_more_rings.patch
user: Simon King <[email protected]>
date: Sun Apr 24 15:28:28 2011 +0200
summary: #9138: Provide the category framework for quotient rings and
free algebras.
changeset: 15990:cf06a8bb75f4
user: Kwankyu Lee <[email protected]>
date: Tue May 10 16:58:20 2011 +0900
summary: Trac #11316: #11316: added weighted degree term orders
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9138#comment:88>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
