#11752: ecl.pyx should not touch SIGPWR neither SIGXCPU when initializing ecl
--------------------------+-------------------------------------------------
Reporter: pcpa | Owner: was
Type: defect | Status: needs_work
Priority: minor | Milestone: sage-4.7.2
Component: interfaces | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Nils Bruin | Author: Paulo César Pereira de Andrade
Merged: | Dependencies:
--------------------------+-------------------------------------------------
Changes (by nbruin):
* status: positive_review => needs_work
Comment:
Ouch, sorry. I tried
{{{
> sage -sh
> cd $SAGE_ROOT/devel/sage/sage
> hg qimport <patch file>
> hg qpush
}}}
and I get failures:
{{{
applying sage-4.7.1-ecl_module.patch
unable to find 'spkg/build/sage-4.7.1/sage/libs/ecl.pxd' for patching
1 out of 1 hunks FAILED -- saving rejects to file
spkg/build/sage-4.7.1/sage/libs/ecl.pxd.rej
unable to find 'spkg/build/sage-4.7.1/sage/libs/ecl.pyx' for patching
1 out of 1 hunks FAILED -- saving rejects to file
spkg/build/sage-4.7.1/sage/libs/ecl.pyx.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh sage-4.7.1-ecl_module.patch
}}}
It looks like the patch file isn't formatted properly! Can you follow the
sage instructions for creating a patch file that applies cleanly to the
distribution? The proposed change is fine, but we have to make sure the
patch file is formatted so that the distribution manager can easily apply
it.
While you're at it, also make sure to include a meaningful commit message
mentioning #11752.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11752#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
