#11709: FareySymbol
-----------------------------+----------------------------------------------
   Reporter:  hmonien        |          Owner:  craigcitro    
       Type:  enhancement    |         Status:  needs_work    
   Priority:  major          |      Milestone:  sage-4.7.2    
  Component:  modular forms  |       Keywords:  Farey symbol  
Work_issues:                 |       Upstream:  N/A           
   Reviewer:  Martin Raum    |         Author:  Hartmut Monien
     Merged:                 |   Dependencies:  None          
-----------------------------+----------------------------------------------

Comment(by mraum):

 I have created a patch that incorporates the pictures. Btw. to create such
 a patch simply type
 {{{
 hg add *.png
 }}}
 in the corresponding directory. Then commit. Don't be irritated by the v4.
 I internally relabelled different versions of the patch, and I cannot
 overwrite your uploads.


 I have changed some lines where you have put your name twice in the author
 section. It is common in Sage to put a list there, to provide the
 possibility to include further authors, which later might contribute.

 The one thing that is irritating is the SL2Z case. Obviously, PSL is not a
 subgroup of SL, so it does not make sense to talk about indices. Also the
 index of SL2 in SL2, as a matter of fact, is 1. In the current
 implemntation generators() equals cosets(), which cannot be right.
 Am I missing anything, that you intent to implement?

 Since you know provide the SL2 generators explicitly, I wonder why you
 don't use [[0,1],[-1,0]] and [[1,1],[0,1]], which are the most common used
 generators. Clearly, your choice is perfectly possible; I just wonder.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11709#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to