#11709: FareySymbol
-----------------------------+----------------------------------------------
Reporter: hmonien | Owner: craigcitro
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.7.2
Component: modular forms | Keywords: Farey symbol
Work_issues: | Upstream: N/A
Reviewer: Martin Raum | Author: Hartmut Monien
Merged: | Dependencies: None
-----------------------------+----------------------------------------------
Changes (by mraum):
* status: needs_work => positive_review
Old description:
> [[BR]]
> FareySymbol is a *fast* implementation of the *KFarey* package for sage.
> The major changes done by me:
>
> - created an object oriented coherent class intereface[[BR]]- implemented
> c++ module with pyx interface
>
> FareySymbol allows the calculation of properties of a general arithmetic
> subgroup. The use with the congruence subgroups Gamma0, Gamma1, GammaH
> is trivial. For a group not implemented in sage the "user" has to define
> a class with a __contains__ (self, M) attribute which returns true or
> false depending on M being in the group or not.
>
> The calculation of the generators, coset representation and genus of
> Gamma(32) takes 62.5 seconds on my laptop. Try this with Magma ... .
>
> sage: time FareySymbol(Gamma(32)) FareySymbol(Congruence Subgroup
> Gamma(32)) Time: CPU 62.50 s, Wall: 62.52 s
New description:
[[BR]]
FareySymbol is a *fast* implementation of the *KFarey* package for sage.
The major changes done by me:
- created an object oriented coherent class intereface[[BR]]- implemented
c++ module with pyx interface
FareySymbol allows the calculation of properties of a general arithmetic
subgroup. The use with the congruence subgroups Gamma0, Gamma1, GammaH is
trivial. For a group not implemented in sage the "user" has to define a
class with a __contains__ (self, M) attribute which returns true or false
depending on M being in the group or not.
The calculation of the generators, coset representation and genus of
Gamma(32) takes 62.5 seconds on my laptop. Try this with Magma ... .
sage: time FareySymbol(Gamma(32)) FareySymbol(Congruence Subgroup
Gamma(32)) Time: CPU 62.50 s, Wall: 62.52 s
'''Apply:'''
1. [attachment:trac-11709_farey_symbol-v6.patch]
--
Comment:
Yes, finally this work gets a positive review. The only change I made is
to adapt the commit message to comply with the standards.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11709#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
