#11682: thematic tutorial on sandpiles
-----------------------------------------+----------------------------------
   Reporter:  dperkinson                 |          Owner:  mvngu          
       Type:  enhancement                |         Status:  needs_work     
   Priority:  major                      |      Milestone:  sage-4.7.2     
  Component:  documentation              |       Keywords:  sandpile       
Work_issues:                             |       Upstream:  N/A            
   Reviewer:  Rob Beezer, John Palmieri  |         Author:  David Perkinson
     Merged:                             |   Dependencies:                 
-----------------------------------------+----------------------------------
Changes (by rbeezer):

  * status:  needs_review => needs_work
  * reviewer:  => Rob Beezer, John Palmieri


Comment:

 David,

 I think this is looking real good.  It'll be a very nice contribution.

 And despite my earlier (unconsidered) ambivalence, the Python blocks
 really should be doctested, or they will eventually become useless (and an
 embarassment).  So I'm glad John P brought it up and that you have those
 reworked.

 Just one technical problem.  The six image files are not available. I
 don't see a "sandpile" subdirectory in
 {{{doc/en/thematic_tutorials/media/}}} after applying the patch, and from
 the sizes of your patches, it looks like a healthy number of bytes are
 AWOL.

 How about manufacturing a patch with '''just''' the images?  That'll be
 really easy to check as a patch on top of the "v5" patch.  I'll presume
 you've done this once and can do it again, but feel free to ask for
 guidance.  With this done, this should move to positive review.

 Thanks for this substantial contribution.

 Rob

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11682#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to