#10335: Add domains for permutation groups
--------------------------------------------+-------------------------------
Reporter: mhansen | Owner: joyner
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.7.2
Component: group theory | Resolution:
Keywords: sd31 | Work_issues:
Upstream: N/A | Reviewer: Robert Miller,
Rob Beezer, Nicolas Borie, Nicolas M. Thiéry
Author: Mike Hansen, David Loeffler | Merged:
Dependencies: #10334 |
--------------------------------------------+-------------------------------
Comment(by rbeezer):
Replying to [comment:47 leif]:
> I'm not sure whether removing a doctest is the proper way to fix a
doctest error... ;-)
I agree. But in this case, I agree with David's argument. This patch
implements a highly desirable feature with many doctests. And if I
understand right, GAP uses some probabilistic algorithms, so we could tie
ourselves in knots trying to rewrite this doctest.
My understanding (and some grep'ing appears to confirm) is that this is a
'''new''' test. Would the patch have gone in without it if it had never
appeared? I think so. If an '''existing''' test were failing, I'd be a
lot less cavalier about dropping it.
Anyway, my $0.02 worth.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10335#comment:48>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
