#10335: Add domains for permutation groups
--------------------------------------------+-------------------------------
Reporter: mhansen | Owner: joyner
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.7.2
Component: group theory | Resolution:
Keywords: sd31 | Work_issues:
Upstream: N/A | Reviewer: Robert Miller,
Rob Beezer, Nicolas Borie, Nicolas M. Thiéry
Author: Mike Hansen, David Loeffler | Merged:
Dependencies: #10334 |
--------------------------------------------+-------------------------------
Comment(by leif):
Replying to [comment:53 davidloeffler]:
> Aaargh! Do what you like, just *MERGE IT SOMEHOW*! If we miss the boat
with this one again, and consequently #11422, #11598, #5048, #11601 and
#10546 end up still trapped in purgatory, I will have to think very
seriously about whether working on Sage in future is a productive use of
my time.
Well, to be honest, it's not my problem that this ticket bit-rottened. I
started merging tickets "officially" into alpha3 about two weeks ago IIRC
(including some you participated in); this ticket got positive review 20
hours ago.
I agree that it's a pity, not just because other already positively
reviewed tickets -- three of the other ones you mentioned still need
review -- depend on this one, but as I told Rob yesterday, it would have
to get rebased anyway, because of (at least) #11749, and I'm not going to
back the latter out (or try to reapply it on top of tickets that haven't
had positive review recently, again having to manually resolve conflicts
and errors, some showing up only later during testing).
We haven't yet talked about the release plans for the final Sage 4.7.2,
but I think there'll still be an alpha4 before we go into feature freeze,
as there are other important things that still have to get fixed and
should be solved in a final.
So IMHO it would be best to wait for the alpha3, hopefully released within
the next days, and then rebase this ticket (and if necessary the others)
on that.
[I didn't touch the tickets having milestone "sage-pending" (including
#11422 and #11598) at all, since I don't know why Jeroen put them there,
although I have to admit I also didn't try to find out, mainly because of
lack of time. I early did ping the authors and reviewers of all other
tickets that were holding up other positively reviewed ones though, with
some success.]
[[BR]]
W.r.t. the doctest with varying output:
It would IMHO be best to give the alternative, also correct result as an
example, too, marking both `# not tested`, with an appropriate comment.
(And perhaps add a real doctest which tests a property common to both.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10335#comment:54>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
