#11760: 'sage-location' shouldn't "initialize" .pc (pkg-config) files more than
once
-----------------------+----------------------------------------------------
Reporter: leif | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-4.7.2
Component: scripts | Keywords: pkgconfig libpng Duplicate definition
SAGE_ROOT
Work_issues: | Upstream: N/A
Reviewer: | Author: Leif Leonhardy
Merged: | Dependencies:
-----------------------+----------------------------------------------------
Comment(by leif):
Replying to [comment:8 leif]:
> Nevertheless, any ''wrong'' definition of `SAGE_ROOT` present during
`initialize_pkgconfig_files()` will be corrected in the subsequent call to
`update_pkgconfig_files()`.
Ah, I see. `update_pkgconfig_files()` is ''not'' called in the ''same''
invocation of `sage-location` if `initialize_pkgconfig_files()` was
called, since `install_moved()` in this case returns `False`.
So we ''could'' in principle add
{{{
#!diff
diff --git a/sage-location b/sage-location
--- a/sage-location
+++ b/sage-location
@@ -68,6 +68,7 @@
write_location_file()
update_library_files()
initialize_pkgconfig_files()
+ update_pkgconfig_files()
return False
elif path != SAGE_ROOT:
# location moved
}}}
but that's IMHO really a minor issue since that situation doesn't occur
unless ''the user'' damages his `pkg-config` files.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11760#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
