#11760: 'sage-location' shouldn't "initialize" .pc (pkg-config) files more than
once
-----------------------+----------------------------------------------------
   Reporter:  leif     |          Owner:                                        
         
       Type:  defect   |         Status:  needs_review                          
         
   Priority:  blocker  |      Milestone:  sage-4.7.2                            
         
  Component:  scripts  |       Keywords:  pkgconfig libpng Duplicate definition 
SAGE_ROOT
Work_issues:           |       Upstream:  N/A                                   
         
   Reviewer:           |         Author:  Leif Leonhardy                        
         
     Merged:           |   Dependencies:                                        
         
-----------------------+----------------------------------------------------

Comment(by leif):

 Ok, I've further improved and normalized both functions...

 Just wonder whether using `use_pat.sub("${SAGE_ROOT}", config)` (where
 `use_pat` is a '''compiled''' pattern matching
 `os.path.abspath(SAGE_ROOT)`) would be faster than
 `config.replace(SAGE_ROOT_absolute, "${SAGE_ROOT}")`.

 (I've factored out `os.path.abspath(SAGE_ROOT)` since it was not only used
 more than once, but also inside the loops. 8/ *shudder*)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11760#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to