#11959: Remove the necessity to set SAGE_PARALLEL_SPKG_BUILD
------------------------------+---------------------------------------------
Reporter: jhpalmieri | Owner: GeorgSWeber
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-4.7.3
Component: build | Keywords: SAGE_PARALLEL_SPKG_BUILD MAKE
-j --jobs
Work_issues: | Upstream: N/A
Reviewer: Leif Leonhardy | Author: John Palmieri
Merged: | Dependencies:
------------------------------+---------------------------------------------
Changes (by leif):
* status: needs_review => needs_work
* reviewer: => Leif Leonhardy
Comment:
`make` doesn't export "its" variables by default. So unless
`SAGE_PARALLEL_SPKG_BUILD` was already defined (and exported) when `make`
was invoked, setting it in the `Makefile` has no effect on programs
(including shells) invoked by `make`. Without using further GNU make
specifics, you'd have to do e.g.
{{{
#!make
build: $(PIPE)
cd spkg && \
"../$(PIPE)" \
"env
SAGE_PARALLEL_SPKG_BUILD='$(SAGE_PARALLEL_SPKG_BUILD)' ./install all 2>&1"
\
"tee -a ../install.log"
}}}
I <3 lengthy env var names...
[[BR]]
It would be better (i.e., safer) to use an absolute filename in the
`include` directive, e.g. `$(SAGE_ROOT)/spkg/parallel_make.cfg`.
I'd perhaps add to the comment there that `.NOTPARALLEL` has no effect on
sub-makes.
[[BR]]
While you're at it, the commit messages are no longer current.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11959#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
