#11926: "make" should run Sage once
---------------------------------------------+------------------------------
Reporter: jdemeyer | Owner: GeorgSWeber
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.7.3
Component: build | Keywords: Makefile build
sage-starts
Work_issues: | Upstream: N/A
Reviewer: John Palmieri, Leif Leonhardy | Author: Jeroen Demeyer
Merged: | Dependencies:
---------------------------------------------+------------------------------
Comment(by jdemeyer):
Replying to [comment:60 jhpalmieri]:
> In [attachment:11926_sage.patch], line 859, I would change "such that"
to "so that".
Done
> After having rewritten the error message in [attachment:trac_11926
-error-msg.patch] myself, I now think it would look better to add blank
lines above and below line 56, the name of the log file. (That's line 59
in [attachment:11926-error-msg-review.patch]). The same might go for line
65 (in the review patch), the commands to try to debug the error, but it's
not as important there.
Well, I think the indentation already makes them stand out. Looking at
the new error message in the description of this ticket, I quite like it.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11926#comment:61>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
