#11900: Serious regression caused by #9138
------------------------------+---------------------------------------------
Reporter: SimonKing | Owner: tbd
Type: defect | Status: needs_work
Priority: critical | Milestone: sage-4.8
Component: performance | Keywords: categories regression
Work_issues: | Upstream: N/A
Reviewer: Jeroen Demeyer | Author: Simon King
Merged: | Dependencies: #9138 #11911
------------------------------+---------------------------------------------
Comment(by SimonKing):
Replying to [comment:99 nthiery]:
> Ah, I see, you are thinking of cythonizing is_subcategories via
> parent_class for *all* categories.
Yes! Currently it would work, even for join categories. On the other hand,
this could be a rather big change (so, better on a different ticket.
> Hmm, I haven't yet made up my mind
> about this. Unless it brings a clear general improvement (and not only
> for the specific regression this patch is about), shalle we not postpone
> that to later, and stick to a more local change (only about Rings and
friends)?
OK.
I don't know if we can do the change for Fields, though. Fields has a
special `__contains__` method, and I don't know if #9138 has really been
strong enough to make it possible to use the default `__contains__`
instead.
Design question:
Apparently you suggest to implement a subclass of Category, so that Rings
and Fields and so on inherit form this class rather than from Category.
The other approach we discussed was to define cython functions and plug
these functions into methods of python classes. I suggest that we do a
couple of benchmarks, to see what's fastest. Doing that now...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:101>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
