#9958: Upgrade python to 2.7.x
---------------------------+------------------------------------------------
Reporter: mhampton | Owner: tbd
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: packages | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: François Bissey
Merged: | Dependencies: #5852, #11986, #12085, #12096,
#12124
---------------------------+------------------------------------------------
Comment(by slabbe):
Replying to [comment:201 fbissey]:
> Actually, you should have a look at what I did for both of these in
[attachment:trac_9958-nfactor_enumerable_word-randomness.patch] and
[attachment:trac_9958-suffix_trees-variations.patch]. If you could give
your opinion on the patches or if you want to submit patches of your own
it would be appreciated.
Hi,
I just look at the suffix tree code (written not by me but by Franco
Saliola). The method `trie_type_dict` is not used anywhere in the file
neither in `sage/combinat/words` neither in all Sage I would guess. So,
it's kind of difficult to guess what the result should be (input and
output blocks are absent in documentation). I think that method was used
by Franco to compare the implementation of `ImplicitSuffixTree` with that
of `SuffixTrie` but not seriously because the output is not practical (one
can't create a `DiGraph` out of it).
Anyway, there are two loops in that method that both go through
`.iteritems()` of a dictionary... Integer indexes present in the result
depends on the ordering of those two loops. So, it is possible that a
third different result is obtained in some other machine or system today
or later. I just made a patch which should be more durable in the long
term.
For the nfactor enumerable file, the fix is perfect.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9958#comment:216>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
