#5048: congruence subgroups are not integrated into the coercion model
-----------------------------+----------------------------------------------
Reporter: ncalexan | Owner: craigcitro
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.8
Component: modular forms | Keywords: congruence subgroup coercion
Work_issues: | Upstream: N/A
Reviewer: Johan Bosman | Author: David Loeffler
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Changes (by johanbosman):
* status: needs_review => positive_review
* reviewer: => Johan Bosman
Old description:
> {{{
> sage: Gamma0(10).1 * Gamma0(5).2
> ---------------------------------------------------------------------------
> TypeError Traceback (most recent call
> last)
>
> /home/ncalexan/.sage/temp/sage.math.washington.edu/4030/_home_ncalexan__sage_init_sage_0.py
> in <module>()
> ----> 1
> 2
> 3
> 4
> 5
>
> /scratch/nca/sage-3.3.alpha0-sage.math-
> only-x86_64-Linux/local/lib/python2.5/site-
> packages/sage/structure/element.so in
> sage.structure.element.MonoidElement.__mul__
> (sage/structure/element.c:7375)()
> 849
> 850
> --> 851
> 852
> 853
>
> TypeError: unsupported operand parent(s) for '*': 'Congruence Subgroup
> Gamma0(10)' and 'Congruence Subgroup Gamma0(5)'
> }}}
> Apply *either*
>
> * [attachment:trac_5048-sl2z_coercion-rebased_for_10452.patch] if using
> Sage 4.7.2.alpha2 or earlier,
> * [attachment:trac_5048-rebased_for_11422.patch] if using Sage
> 4.7.2.alpha3 or later.
>
> (There is no difference in functionality either way, it's just that the
> original patch won't apply because some context lines changed.)
New description:
{{{
sage: Gamma0(10).1 * Gamma0(5).2
---------------------------------------------------------------------------
TypeError Traceback (most recent call
last)
/home/ncalexan/.sage/temp/sage.math.washington.edu/4030/_home_ncalexan__sage_init_sage_0.py
in <module>()
----> 1
2
3
4
5
/scratch/nca/sage-3.3.alpha0-sage.math-
only-x86_64-Linux/local/lib/python2.5/site-
packages/sage/structure/element.so in
sage.structure.element.MonoidElement.__mul__
(sage/structure/element.c:7375)()
849
850
--> 851
852
853
TypeError: unsupported operand parent(s) for '*': 'Congruence Subgroup
Gamma0(10)' and 'Congruence Subgroup Gamma0(5)'
}}}
Apply
* [attachment:trac_5048-rebased_for_11422.patch]
--
Comment:
The patch still applies to 4.8.alpha4, the code looks sound, and all tests
in sage.modular pass.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5048#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
