#5048: congruence subgroups are not integrated into the coercion model
-----------------------------+----------------------------------------------
Reporter: ncalexan | Owner: craigcitro
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.8
Component: modular forms | Keywords: congruence subgroup coercion
Work_issues: | Upstream: N/A
Reviewer: Johan Bosman | Author: David Loeffler
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Comment(by GeorgSWeber):
Hi Johan,
thanks for looking at this one (I guess you're on SD 35 --- if so, I do
envy you)!!
I dimly remember that this patch introduced a function with a missing
doctest in "sage/modular/arithgroup/congroup_sl2z.py":
96 def __call__(self, x, check=True):
97 r"""
98 Create an element of self from x. If check=True
(the default), check
99 that x really defines a 2x2 integer matrix of det
1.
100 """
101 return ArithmeticSubgroupElement(self, x,
check=check)
102
I'm sorry I never got round to poke David about that (otherwise, the
changes were OK for me) --- could you please have second look and check
that independently ("sage --coverage ...modular/arithgroups/" or the like
should show it)?
Thanks a lot in advance!
Cheers,
Georg
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5048#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
