#5048: congruence subgroups are not integrated into the coercion model
--------------------------------------------+-------------------------------
   Reporter:  ncalexan                      |          Owner:  craigcitro       
           
       Type:  enhancement                   |         Status:  positive_review  
           
   Priority:  major                         |      Milestone:  sage-4.8         
           
  Component:  modular forms                 |       Keywords:  congruence 
subgroup coercion
Work_issues:                                |       Upstream:  N/A              
           
   Reviewer:  Johan Bosman, Georg S. Weber  |         Author:  David Loeffler   
           
     Merged:                                |   Dependencies:                   
           
--------------------------------------------+-------------------------------

Comment(by johanbosman):

 Replying to [comment:20 davidloeffler]:
 > Hang on a minute.
 >
 > It is true that there is a doctest missing for this call method, but the
 missing doctest gets added in the next patch in the series (#11601). So I
 think we can ignore it here, since #11601 has a positive review; and I can
 safely reinstate Johan's positive review.
 >
 > So: '''ignore''' the patch(es) I just uploaded -- it is not needed. I
 tried to obliterate the first patch by uploading a new blank patch on top
 of it, but made a hash of that. Perhaps it's time I went to bed.
 Indeed.  I was about to mention the same thing, but your comment crossed
 mine. :).

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5048#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to