#12170: Genus computation (using singular) and _singular_ object for function 
filed
----------------------------------+-----------------------------------------
   Reporter:  sydahmad            |          Owner:  AlexGhitza                 
    
       Type:  enhancement         |         Status:  needs_work                 
    
   Priority:  minor               |      Milestone:  sage-5.0                   
    
  Component:  algebraic geometry  |       Keywords:  function field, genus, 
singular
Work_issues:                      |       Upstream:  N/A                        
    
   Reviewer:                      |         Author:  Syed Ahmad Lavasani        
    
     Merged:                      |   Dependencies:  #9054                      
    
----------------------------------+-----------------------------------------

Comment(by was):

 Just a quick observation.  The docstring for is_RationalFunctionField
 claims that it checks if the input is "of rational function field *type*".
 However, that is not what it does.  It checks if it is either of rational
 function field type, or if it isn't, it also checks if the input is in the
 category of Function Fields and is equal to its base.  I think the
 docstring should be changed.  Also, be sure to include an example that
 illustrates something that is not of RationalFunctionField type but is in
 the category FunctionFields().
 {{{
         960     def is_RationalFunctionField(x):
         961         """
         962         Return True if ``x`` is of rational function field
 type.
 ...
         971         """
         972         if isinstance(x, RationalFunctionField): return True
         973         if (x in FunctionFields()):
         974             return x == x.base_field()
         975         else:
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12170#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to