#11375: speed up computation of level one eisenstein series
------------------------------------------+---------------------------------
Reporter: was | Owner: craigcitro
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-4.8
Component: modular forms | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Craig Citro, William Stein | Author: William Stein,
Craig Citro
Merged: | Dependencies:
------------------------------------------+---------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => positive_review
* reviewer: => Craig Citro, William Stein
* author: => William Stein, Craig Citro
Comment:
LGTM! Too bad my name won't appear in the hg repo for this code anymore.
;)
I'm really glad to see that you did #12265; I didn't want to figure out
the right way to get that in order (the FLINT QQX stuff was still in flux
when I wrote this patch IIRC), but it's what kept me from actually pushing
any harder to get it in.
Do you happen to have some timing comparisons for the actual coefficient
computation vs. the whole eisenstein_series_qexp call? I'm curious how low
the overhead is now.
The Py_GET_ITEM is indeed gross, but a necessary evil.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11375#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
