#11375: speed up computation of level one eisenstein series
------------------------------------------+---------------------------------
   Reporter:  was                         |          Owner:  craigcitro         
       
       Type:  enhancement                 |         Status:  positive_review    
       
   Priority:  minor                       |      Milestone:  sage-5.0           
       
  Component:  modular forms               |       Keywords:                     
       
Work_issues:                              |       Upstream:  N/A                
       
   Reviewer:  Craig Citro, William Stein  |         Author:  William Stein, 
Craig Citro
     Merged:                              |   Dependencies:                     
       
------------------------------------------+---------------------------------
Changes (by craigcitro):

  * status:  needs_review => positive_review


Comment:

 LGTM on the power series bit ... glad the tests caught it. :)

 One wildly minor nit: the conversion from list -> poly -> power series has
 comments interspersed about what it's doing a faster version of; it might
 be nice for those to be either grouped at the top or at least always
 before the code they're replaced by. (So lines 102-103 in eis_series.py
 could be moved above line 98 or 99, respectively.) Putting them all
 together might also be a nice TODO list for anyone looking to speed up
 general power series creation.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11375#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to