#12282: Fix strcmp() will NULL argument in termcap library
------------------------+---------------------------------------------------
   Reporter:  jdemeyer  |          Owner:  tbd                                  
    
       Type:  defect    |         Status:  needs_review                         
    
   Priority:  blocker   |      Milestone:  sage-4.8                             
    
  Component:  packages  |       Keywords:  sd35.5                               
    
Work_issues:            |       Upstream:  Reported upstream. Little or no 
feedback.
   Reviewer:            |         Author:  Jeroen Demeyer                       
    
     Merged:            |   Dependencies:                                       
    
------------------------+---------------------------------------------------

Comment(by jdemeyer):

 Replying to [comment:10 wjp]:
 > I'm not sure how you triggered this error in sage (and therefore if the
 actual behaviour is really relevant)
 There is more info at #11970.  It's a combination of the new readline spkg
 at #11970 and the patch at #12263, and it also depends on the gcc version.

 > but are you sure this is the right behaviour when TERM is unset? I'd
 probably expect an unset TERM to behave the same as an empty TERM.
 In practice, this will be the case.  The `tgetent()` code checks whether
 the argument `char *term` equals the environment variable "TERM".
 Normally, `term` will not be the empty string.  But you are certainly
 right that
 {{{
 term_name = getenv("TERM");
 if (!term_name)
     term_name = "";
 }}}
 would also work.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12282#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to