#12282: Fix strcmp() with NULL argument in termcap library
------------------------+---------------------------------------------------
Reporter: jdemeyer | Owner: tbd
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-4.8
Component: packages | Keywords: sd35.5
Work_issues: | Upstream: Reported upstream. Little or no
feedback.
Reviewer: | Author: Jeroen Demeyer
Merged: | Dependencies:
------------------------+---------------------------------------------------
Changes (by jdemeyer):
* status: needs_work => needs_review
Comment:
Replying to [comment:13 ppurka]:
> Just a small comment: line 10 of Makefile.patch should say
>
> +# I '''commented''' this (William), since SAGE install should work as
not-root.
Thanks, I fixed this comment.
> My experience with Makefiles is quite elementary, so I can not comment
on Makefile.patch.
Luckily, there is no need to review the Makefile. This is an old patch
which was directly applied to the src/ directory, instead of being applied
by `spkg-install`. I restored the upstream sources and made an explicit
patch. So the file `patches/Makefile.patch` doesn't need to be reviewed
for this ticket.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12282#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
