#12282: Fix strcmp() with NULL argument in termcap library
------------------------+---------------------------------------------------
Reporter: jdemeyer | Owner: tbd
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-4.8
Component: packages | Keywords: sd35.5
Work_issues: | Upstream: Reported upstream. Little or no
feedback.
Reviewer: | Author: Jeroen Demeyer
Merged: | Dependencies:
------------------------+---------------------------------------------------
Comment(by leif):
Replying to [comment:13 ppurka]:
> Just a small comment: line 10 of Makefile.patch should say
>
> +# I '''commented''' this (William), since SAGE install should work as
not-root.
>
> My experience with Makefiles is quite elementary, so I can not comment
on Makefile.patch. Aside from that, the rest of the changes looks good.
Well, William's change(s) are more or less superfluous anyway, so I'd drop
them. (I looked at the spkg a while ago, but the little changes weren't
worth a ticket or new spkg.
* Instead of changing the target `all`, we should use `$MAKE
libtermcap.a`, then the info files won't get built, and hence not
installed (also '''without''' commenting out the `for` loop).
* Commenting out `oldinstalldir=...` isn't necessary, but also wrong; it
should either be set to the empty string, or (if we assume nobody builds
Sage as root) left as is, since the lines of the receipt that try to
install into `/usr/include` are preceded by dashs anyway, i.e. `make`
doesn't fail because of lacking file permissions.
In the latter case we wouldn't have to patch the Makefile at all.
(Slightly OT: Should we in general issue a warning -- or abort the build
-- if someone builds Sage as root?)
[[BR]]
Another minor thing: In `spkg-install`, `-m64` should be '''ap'''pended,
since it should take precedence over whatever a user specified in
`CFLAGS`.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12282#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
