#12215: Memleak in UniqueRepresentation, @cached_method
-----------------------+----------------------------------------------------
   Reporter:  vbraun   |          Owner:  rlm                                   
    
       Type:  defect   |         Status:  needs_review                          
    
   Priority:  major    |      Milestone:  sage-4.8                              
    
  Component:  memleak  |       Keywords:  UniqueRepresentation cached_method 
caching
Work_issues:           |       Upstream:  N/A                                   
    
   Reviewer:           |         Author:  Simon King                            
    
     Merged:           |   Dependencies:  #11115 #11900                         
    
-----------------------+----------------------------------------------------
Changes (by SimonKing):

  * status:  needs_work => needs_review
  * work_issues:  fix it... =>


Comment:

 I updated the second patch, which should solve the problem!!

 First of all: The segfault in the tests of sage/libs/pari/gen.pyx was due
 to my test for the new dealloc method. Following Jeroen's advice, I
 removed it and stated in the docs that Sage not crashing at exit is an
 indirect doctest.

 Then, all failures in sage/combinat could be fixed by using a ''strong''
 cache for `SymmetricFunctions(...)`. So, I simply overrode the
 `__classcall__` method inherited from `UniqueRepresentation`.

 I just tested that with the new patch all tests in sage/combinat and
 sage/libs/pari/gen.pyx pass. The others passed even with the old patch
 version, so that I am confident that they will pass as well (of course,
 one must try!).

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12215#comment:50>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to