#11900: Serious regression caused by #9138
-------------------------------------------------------------+--------------
Reporter: SimonKing | Owner:
tbd
Type: defect | Status:
needs_review
Priority: critical | Milestone:
sage-5.0
Component: performance | Keywords:
categories regression
Work_issues: | Upstream:
N/A
Reviewer: Jeroen Demeyer, Nicolas M. Thiéry, Simon King | Author:
Simon King
Merged: | Dependencies:
#11319, #9138, #11911, #9562
-------------------------------------------------------------+--------------
Comment(by nthiery):
Replying to [comment:231 SimonKing]:
> Fixed and ready for review! The problem has not been in
`lazy_class_attribute` but in the classcall method of `Category_singleton`
in combination with a too short type used in `FastHashable_class`.
>
> Apply trac11900_category_speedup_combined.patch
trac11900_fix_singleton_hash.patch
Good catch Simon!
Given that this issue was non trivial to pinpoint, do you see a way to add
a doctest to FastHashClass? Say with a small class returning a large hash
that would cause the same overflow on OS X?
With that, and assuming that all test pass, I am happy to put back the
positive review.
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:233>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
