#11900: Serious regression caused by #9138
-------------------------------------------------------------+--------------
   Reporter:  SimonKing                                      |          Owner:  
tbd                         
       Type:  defect                                         |         Status:  
needs_review                
   Priority:  critical                                       |      Milestone:  
sage-5.0                    
  Component:  performance                                    |       Keywords:  
categories regression       
Work_issues:                                                 |       Upstream:  
N/A                         
   Reviewer:  Jeroen Demeyer, Nicolas M. ThiƩry, Simon King  |         Author:  
Simon King                  
     Merged:                                                 |   Dependencies:  
#11319, #9138, #11911, #9562
-------------------------------------------------------------+--------------

Comment(by SimonKing):

 Replying to [comment:233 nthiery]:
 > Given that this issue was non trivial to pinpoint, do you see a way to
 add a doctest to FastHashClass? Say with a small class returning a large
 hash that would cause the same overflow on OS X?

 `FastHashable_class._hash` must be explicitly assigned - i.e., one could
 try to create an example that would crash on machines where the biggest
 `Py_ssize_t` does not fit into an `int`, by explicitly assigning such
 value. `CategorySingleton` assigns `id(cls)` to the attribute `_hash` of
 the unique instance of `cls` - and `Sets` happens to have an address that
 doesn't fit into an int.

 Cheers,
 Simon

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:234>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to