#12261: Bring Doctest coverage for element_ext_pari.py to 100%
-----------------------------------+----------------------------------------
Reporter: roed | Owner: mvngu
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: doctest | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: David Roe
Merged: | Dependencies:
-----------------------------------+----------------------------------------
Changes (by kcrisman):
* reviewer: => Karl-Dieter Crisman
Comment:
I'm finding it hard to find any problems with this that aren't nearly
trivial. Comments that may or may not warrant addressing:
* Typo
{{{
The has of this element
}}}
* `def __compat(self, other):` removed because...? (I assume this is
obvious to someone familiar with this code, but they haven't reviewed
this.)
* I really like that you actually mention that the doctests are indirect
when they are. We need to do that more.
* You got 'em:
{{{
$ ../../sage -coverage
../../devel/sage/sage/rings/finite_rings/element_ext_pari.py
----------------------------------------------------------------------
../../devel/sage/sage/rings/finite_rings/element_ext_pari.py
SCORE ../../devel/sage/sage/rings/finite_rings/element_ext_pari.py: 100%
(31 of 31)
----------------------------------------------------------------------
}}}
and testing seems fine.
* Although not really part of this ticket, one ''could'' add this to the
reference manual; if so, might as well change {{{See self.square_root()}}}
to {{{See :meth:`square_root`}}} or whatever the right syntax is.
* Really picky; is it Pari or pari, officially? I feel like this was
unified at some point in our docs.
* There is a typo that has nothing to do with this ticket but should be
fixed - {{{probabalistic}}}
Let me know what you want to deal with on a refresh (probably at least the
typos) and otherwise this should go in.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12261#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
