#12261: Bring Doctest coverage for element_ext_pari.py to 100%
---------------------------------------------+------------------------------
   Reporter:  roed                           |          Owner:  mvngu     
       Type:  enhancement                    |         Status:  needs_work
   Priority:  major                          |      Milestone:  sage-5.0  
  Component:  doctest                        |       Keywords:            
Work_issues:  commit message, PARI (maybe?)  |       Upstream:  N/A       
   Reviewer:  Karl-Dieter Crisman            |         Author:  David Roe 
     Merged:                                 |   Dependencies:            
---------------------------------------------+------------------------------
Changes (by kcrisman):

  * status:  needs_review => needs_work
  * work_issues:  => commit message, PARI (maybe?)


Comment:

 That's ok.    Patch is fine.

 I don't feel comfortable giving final positive review because of the
 `__compat` issue - again, I'm sure this is obvious to those in the know,
 but I don't want to be responsible for removing a function it turns out is
 crucial to someone (even an underscore function).

 Also (less crucially) now I realize that I think the
 [http://pari.math.u-bordeaux.fr/ folks in Bordeaux] ''really'' want PARI
 and not Pari... I just don't know, and hate all that stuff, but it's
 probably important to them.

 Jeroen probably also won't accept this due to the commit "message".  I'm
 really sorry... I know from experience how much work doctest upgrades end
 up taking when you think they will be a 5-minute job.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12261#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to