#11599: Wrap fan morphism in toric morphism
----------------------------------+-----------------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: algebraic geometry | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Andrey Novoseltsev | Author: Volker Braun
Merged: | Dependencies:
----------------------------------+-----------------------------------------
Comment(by novoselt):
The renaming is great, but do we need `_class` on the end of
`_morphism_class`, `_homset_class`, `_point_class`,
`_point_homset_class`??? It seems to me that these functions return actual
morphisms and homsets, not classes, so it is confusing (and it was
especially confusing when they were undocumented). I propose getting rid
of `_class` suffix.
There is also no consistency in "a word for homset": I think I saw
"homset", "hom set", "hom-set", "Hom-set" and maybe other variants with
capitalization-spacing-dashing. It would be nice to settle with a single
one. Personally I prefer "Hom-set" with close second "homset". Or,
perhaps, they should be referred to as "sets of morphisms".
Otherwise I am fine with the third patch, so only the fun part is left!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11599#comment:35>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
