#12449: Improve the way that sage evaluates symbolic functions on basic types
-----------------------------+----------------------------------------------
Reporter: bober | Owner: bober
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.0
Component: symbolics | Keywords: gamma function
Work_issues: | Upstream: N/A
Reviewer: Burcin Erocal | Author: Jonathan Bober
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => needs_work
* reviewer: => Burcin Erocal
* author: bober => Jonathan Bober
Comment:
Thanks for the patch. I agree that considering float and complex types
separately in the fast evaluation path makes sense for speed. However,
this causes inconsistencies with the results you get when a value is
substituted into the expression.
We still need to modify the `py_tgamma()` function in
`sage/symbolic/pynac.pyx` to fix this:
{{{
sage: gamma(x).subs(x=6.r)
120.0
}}}
AFAICT (without applying the patch and testing), attachment:12449.patch
removes the `try/except` block around `return getattr(args[0],
self._name)()`, disabling the call to `BuiltinFunction.__call__` later on
in the function body.
This would be a good occasion to merge my patch from
attachment:trac_1173-move_call.patch:ticket:1173. I'll try to rebase your
patch on top of that.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12449#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
