#11709: FareySymbol
-------------------------------+--------------------------------------------
Reporter: hmonien | Owner: craigcitro
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: modular forms | Resolution:
Keywords: Farey symbol | Work_issues:
Upstream: N/A | Reviewer: Martin Raum, Leif Leonhardy
Author: Hartmut Monien | Merged:
Dependencies: |
-------------------------------+--------------------------------------------
Comment(by davidloeffler):
I tried installing {{{trac-11709_farey_symbol-sage-4.8.patch}}} this on
the latest Sage beta (5.0.beta6), which brought up a couple of minor
issues:
(1) There was a conflict in sage/modular/all.py (easily fixable, caused by
#11601 merged in 5.0.beta1). Other than that, the patch applies OK.
(2) Building gave a curious warning:
{{{
----------------------------------------------------------
sage: Building and installing modified Sage library files.
Installing c_lib
scons: `install' is up to date.
Updating Cython code....
Building modified file sage/modular/arithgroup/farey_symbol.pyx.
setup.py:650: UserWarning: could not find dependency <string> included in
/storage/masiao/sage-5.0.beta6/local/lib/python/site-
packages/Cython/Includes/libcpp/string.pxd. I will assume it is a system
C/C++ header.
warnings.warn(msg+' I will assume it is a system C/C++ header.')
setup.py:650: UserWarning: could not find dependency <vector> included in
/storage/masiao/sage-5.0.beta6/local/lib/python/site-
packages/Cython/Includes/libcpp/vector.pxd. I will assume it is a system
C/C++ header.
warnings.warn(msg+' I will assume it is a system C/C++ header.')
Executing 1 command (using 1 thread)
python `which cython` --cplus --old-style-globals --disable-function-
redefinition --embed-positions --directive
cdivision=True,autotestdict=False,fast_getattr=True
-I/storage/masiao/sage-5.0.beta6/devel/sage-main -o
sage/modular/arithgroup/farey_symbol.cpp
sage/modular/arithgroup/farey_symbol.pyx
sage/modular/arithgroup/farey_symbol.pyx -->
/storage/masiao/sage-5.0.beta6/local/lib/python2.7/site-
packages//sage/modular/arithgroup/farey_symbol.pyx
Time to execute 1 command: 3.33421301842 seconds
Finished compiling Cython code (time = 5.61644482613 seconds)
}}}
Other than that, it looks pretty good -- thanks for your work on this! I'm
running the test suite now. If everything goes OK I'll upload my rebase of
the patch.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11709#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
