#11709: FareySymbol
-------------------------------+--------------------------------------------
Reporter: hmonien | Owner: craigcitro
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: modular forms | Resolution:
Keywords: Farey symbol | Work_issues:
Upstream: N/A | Reviewer: Martin Raum, Leif Leonhardy,
David Loeffler
Author: Hartmut Monien | Merged:
Dependencies: |
-------------------------------+--------------------------------------------
Changes (by davidloeffler):
* status: needs_work => needs_review
* reviewer: Martin Raum, Leif Leonhardy => Martin Raum, Leif Leonhardy,
David Loeffler
Comment:
I've uploaded a new patch which is almost 100% identical to Hartmut's but
with a tiny change so it applies to the current v5.0 beta; and a reviewer
patch, which makes changes to the existing classes so {{{generators}}}
calls Hartmut's code by default (while still falling back to the old code
when necessary).
The only significant change I've made concerns the output of "generators"
for even subgroups with elliptic points of order 3 but not of order 2.
Rather than adding -1 on to the end of the generators list, I've modified
the code so it returns generators of order 6 for the odd self-paired
sides; so now the list of generators is genuinely minimal. I also had to
tinker with the signal handling slightly to get rid of a tedious crash
when doctesting.
If Hartmut or anyone else is willing to sign off on my patch, I think this
is ready to go in.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11709#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
