#11306: Upgrade unitary check for RDF/CDF matrices
------------------------------+---------------------------------------------
Reporter: rbeezer | Owner: jason, was
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-5.0
Component: linear algebra | Keywords: days30
Work_issues: | Upstream: N/A
Reviewer: David Loeffler | Author: Rob Beezer
Merged: | Dependencies: #11027, #10848, #11277
------------------------------+---------------------------------------------
Description changed by rbeezer:
Old description:
> This is an upgrade of the {{{is_unitary()}}} method, based on experience
> building {{{is_normal()}}}, {{{is_hermitian()}}}. (#10848, #11104)
>
> One test is discovering a bug elsewhere (#11248), so needs to be adjusted
> slightly to preserve that discovery, though at this writing, the test is
> disabled (#11277).
>
> (a) Adds a "orthonormal" variant, which is now the default, based on the
> Schur decomposition, an idea used in the other two methods, but not
> considered here previously.
>
> (b) Makes the existing naive algorithm a bit more efficent by using the
> break command twice.
>
> (c) Fixes an ommission in the naive algorithm where the loop on {{{i}}}
> previously did not start at zero.
>
> (d) Upgraded error-checking on tolerance parameter.
>
> (e) Docstring upgraded to reflect changes above.
>
> '''Depends on:'''
> 1. #11027
> 1. #10848
> 1. #11277
>
> '''Apply:'''
> 1. [attachment:trac_11306-upgrade-unitary-matrix-check.patch]
New description:
This is an upgrade of the {{{is_unitary()}}} method, based on experience
building {{{is_normal()}}}, {{{is_hermitian()}}}. (#10848, #11104)
One test is discovering a bug elsewhere (#11248), so needs to be adjusted
slightly to preserve that discovery, though at this writing, the test is
disabled (#11277).
(a) Adds a "orthonormal" variant, which is now the default, based on the
Schur decomposition, an idea used in the other two methods, but not
considered here previously.
(b) Makes the existing naive algorithm a bit more efficent by using the
break command twice.
(c) Fixes an ommission in the naive algorithm where the loop on {{{i}}}
previously did not start at zero.
(d) Upgraded error-checking on tolerance parameter.
(e) Docstring upgraded to reflect changes above.
'''Depends on:'''
1. #11027
1. #10848
1. #11277
'''Apply:'''
1. [attachment:trac_11306-upgrade-unitary-matrix-check.patch]
1. [attachment:trac_11306-docfix.patch]
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11306#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.