#12043: Hecke series for overconvergent modular forms
------------------------------+---------------------------------------------
Reporter: lauder | Owner: craigcitro
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-5.0
Component: modular forms | Keywords:
Work_issues: | Upstream: N/A
Reviewer: David Loeffler | Author: Alan Lauder
Merged: | Dependencies:
------------------------------+---------------------------------------------
Changes (by newvalueoldvalue):
* reviewer: => David Loeffler
* author: lauder => Alan Lauder
Comment:
Replying to [comment:11 lauder]:
> I have applied your patch (with Sebastian's help) and then made my
changes. I created a new patch myself: hopefully I did the right thing. In
any case, I will email you my new source code directly (just in case I
messed up).
No problems there, the patch applied fine.
> Note that your new version failed on a few tests on my machine: there
was a stray "print" statement you must have put in sometime; also, it
complained about some alteration you made to the little function for
testing if a weight list was valid. I did not understand what was
happening with the latter, so I have not touched this: when I tested my
new version it passed everything OK except that weight list one.
I see what's happened there -- silly mistake on my part, I'll fix it.
> I tried to address all of your smaller concerns. The only substantial
change was that I altered the random_new_basis_modp function so that it
does not waste time changing between matrices and lists: this also
involved a small change to the complementary_spaces_modp function.
>
> I meant to check why the new version was slower for large p, but forgot.
Perhaps you could have a look at whether using eisenstein series over Q is
slowing down the computation of E_(p-1) for, say, p = 79, N = 1, k = 2 and
m = 3.
The new version is actually about 50 times faster. For instance, computing
10000 terms of E_{78} mod 79 takes 10.23 seconds with your old code, and
0.49 seconds with the new code.
> Anyway, many thanks again for all the improvements you made to the code!
>
> Best wishes
>
> Alan.
No problem. I am a bit busy at the moment, but when I get a chance I will
look at your changes, sort out the last few minor issues and then I think
it'll be good to go.
Best regards, David
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12043#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
