#12043: Hecke series for overconvergent modular forms
----------------------------------+-----------------------------------------
Reporter: lauder | Owner: craigcitro
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-5.0
Component: modular forms | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: David Loeffler
Authors: Alan Lauder | Merged in:
Dependencies: #12724, #12740 | Stopgaps:
----------------------------------+-----------------------------------------
Changes (by davidloeffler):
* status: needs_work => needs_review
* dependencies: => #12724, #12740
Comment:
I've uploaded a new revised version, in two forms:
[attachment:trac_12043-part4.patch] is the difference from the previous
version, and [attachment:trac_12043-all.patch] is a single patch combining
the effects of the four patches so far.
This version is dependent on two new tickets #12724 and #12740. The first
of these (already positively reviewed, thanks Alex!) adds options for
different normalizations to the top-level Eisenstein series function,
incorporating the functionality from the {{{ eisen_series }}} function in
Alan's original patch. The second is a complete overhaul of the
!ModularFormsRing code, which means (among other things) that it can now
be required to return generators for the mod p modular forms; this removes
a possible cause of the algorithm failing to terminate (if one of the
generators returned by !ModularFormsRing happened to be divisible by p,
which could easily have happened with the old code). I've also applied a
number of optimizations, particularly for level 1 modular forms, as
described in my last few comments.
I think this is ready to go now. All that's required is for someone to
have a look at my part4 patch and verify that the changes look reasonable.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12043#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
