#12800: Upgrade zlib to 1.2.6
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: packages | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Michael Orlitzky, Julien
Puydt, Leif Leonhardy
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by leif):
Replying to [comment:10 jdemeyer]:
> Replying to [comment:9 Snark]:
> > Does that loop works even if the ../patches/ directory is empty? Or
does it give a file not found error?
>
> If `../patches` is either empty or non-existent, then `../patches/*`
will expand literally to "`../patches/*`". Since "`../patches/*`" isn't a
file, the line
> {{{
> [ -f "$patch" ] || continue
> }}}
> will ensure that there are no error messages.
Yes, but it then would make more sense to `break` rather than `continue`.
But to perform some loop-invariant code motion, it would be better to just
use
{{{
#!sh
ls ../patches/*.patch &>/dev/null &&
echo "Applying patches to upstream source..." &&
for patch in ../patches/*.patch; do
...
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12800#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
