#12800: Upgrade zlib to 1.2.6
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: packages | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Michael Orlitzky, Julien
Puydt, Leif Leonhardy
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by leif):
Replying to [comment:14 jdemeyer]:
> Replying to [comment:11 leif]:
> > Yes, but it then would make more sense to `break` rather than
`continue`.
> I don't think there is anything wrong with my code. It's simple and
actually catches more special cases than your proposals (such as
`patches/foo.patch` being a directory).
Well, I think the only "special cases" we want to (or have to) handle here
are:
* `../patches/` doesn't exist.
* The directory exists, but it is empty, or at least doesn't contain
files matching `*.patch`.
(I won't insist on changing the `continue`, but it seems more natural [and
actually is more efficient] to place a single test outside the loop.
Also, conditionally printing "Applying patches..." seems reasonable to
me.)
----
If you wanted to go triple-safe, you'd have to use `[ -r "$patch" ]`
instead of `[ -f ... ]`.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12800#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
