#11930: disallow non-smooth hyperelliptic curves, and let hyperelliptic curves
know
they are not singular
-------------------------------------------------------------+--------------
Reporter: dkrenn | Owner:
cremona
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-5.1
Component: elliptic curves | Resolution:
Keywords: hyperelliptic curve singular smooth sd35 | Work issues:
Report Upstream: N/A | Reviewers:
Marco Streng, Damiano Testa, David Eklund
Authors: Daniel Krenn, Marco Streng, Damiano Testa | Merged in:
Dependencies: | Stopgaps:
-------------------------------------------------------------+--------------
Comment (by mstreng):
Replying to [comment:32 davideklund]:
> Here are two more beginner questions related to these patches:
It may be better to ask these in email or on the mailing lists, but I'll
just answer them anyway.
>
> I have a recurring doc-test failure (Sage 5.0 on Mac OS lion) so I can't
really doc-test these patches locally without failures. But I interpret
what the patch-bot has done on this ticket as sufficient for a positive
review as far as doc-testing goes (it seems that all tests pass). Sounds
reasonable?
I'm not sure whether just using the patchbot is ok. According to the
[http://www.sagemath.org/doc/developer/walk_through.html#reviewing-a-patch
developer's guide], you are supposed to run the tests marked "#long" as
well, and I don't see where the patchbot does this.
As for your failing tests, any tests that fail on an unpatched Sage can be
safely ignored, they are not due to the patch.
>
> The patch-bot's blue blob and the "plug-in failed" I believe is only
about trailing white space, and therefore harmless. Sounds reasonable?
In this particular case, it is ok.
In detail: it seems that many people are very annoyed by trailing
whitespaces on non-empty lines (see [http://groups.google.com/group/sage-
devel/browse_thread/thread/f6a783b3a52bfa5d/30809dba7cfb13dd here]), hence
don't want any new ones to be introduced. That's probably where the plugin
came from in the first place. In any case, I just checked and this patch
does not introduce any new trailing whitespaces on non-empty lines. I did
change two lines that already had trailing whitespaces, which I didn't
notice, so I did not remove them. That's where the plugin warning comes
from.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11930#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
