#11930: disallow non-smooth hyperelliptic curves, and let hyperelliptic curves
know
they are not singular
-------------------------------------------------------------+--------------
Reporter: dkrenn | Owner:
cremona
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-5.1
Component: elliptic curves | Resolution:
Keywords: hyperelliptic curve singular smooth sd35 | Work issues:
Report Upstream: N/A | Reviewers:
Marco Streng, Damiano Testa, David Eklund
Authors: Daniel Krenn, Marco Streng, Damiano Testa | Merged in:
Dependencies: | Stopgaps:
-------------------------------------------------------------+--------------
Comment (by mstreng):
Replying to [comment:29 davideklund]:
> I'm not sure what this means or how to get rid off the fuzz.
When applying the patch, mercurial will look for a certain block of code
and replace it by another. The code to look for also has three surrounding
unchanged lines on each side. Fuzz means that there is a slight mismatch
in the surrounding code, due to changes in Sage between after I wrote the
patch. More precisely, fuzz n means that a block can only be matched if
the outermost n lines of the surrounding code are ignored. I've seen
patches be rejected because of fuzz 2, but I think fuzz 1 is fine: there
are still 2 lines unchanged around every patched line.
In this particular case, it means that a doctest nearby one of the changed
doctests in hyperelliptic_finite_field.py has changed since I wrote the
patch.
To get rid of the fuzz, the patch can be rebased (apply to latest version,
then qrefresh and export), but I don't think it is necessary with fuzz 1.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11930#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
