#12299: Advance Jmol Interactive Features in Flask Notebook
----------------------------------------+-----------------------------------
Reporter: gutow | Owner: jason, mpatel, was
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.1
Component: notebook | Resolution:
Keywords: Jmol, 3D, notebook | Work issues:
Report Upstream: N/A | Reviewers:
Authors: gutow | Merged in:
Dependencies: #11080,#11078,#11503 | Stopgaps:
----------------------------------------+-----------------------------------
Comment (by gutow):
Replying to [comment:14 kcrisman]:
> Scarily, I managed to actually get the new notebook installed.
Apparently.
>
> Some comments:
> * I think you have to update
[attachment:trac_12299_plot_3D_static_img.patch]. I see three different
changesets to plot/plot3d/base.pyx, all of which seem to do something
similar (namely, ask plot3d to make a Tachyon picture if Jmol fails). My
guess is that you just exported the patches on top of each other; that's
happened to me in the past too.
> * In fact, I think the same thing has happened (again!) with the sagenb
patch as strogdon indicates happened before.
This is odd. I only see one patch in the file...I'll check it again. I
also don't understand how you can get multiple patches if you only make
one commit. Is something finicky about hg within sage?
> * Sadly, even the {{{__init__}}} method needs at least a minimal
docstring and test in your new interface class. There are also some
extremely minor formatting issues in that file, but clearly no need to
work on that until the rest has been reviewed.
I will work on the doctest. That's not a big deal. Thanks for pointing
it out. I missed that one.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12299#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
