#12299: Advance Jmol Interactive Features in Flask Notebook
---------------------------------------------------------------+------------
Reporter: gutow | Owner:
jason, mpatel, was
Type: enhancement | Status:
needs_work
Priority: major | Milestone:
sage-5.2
Component: notebook | Resolution:
Keywords: Jmol, 3D, notebook | Work issues:
create upstream pull request, double patch
Report Upstream: Not yet reported upstream; Will do shortly. | Reviewers:
Karl-Dieter Crisman
Authors: Jonathan Gutow | Merged in:
Dependencies: #11080,#11078,#11503 | Stopgaps:
---------------------------------------------------------------+------------
Comment (by ppurka):
Replying to [comment:24 gutow]:
> Replying to [comment:23 kcrisman]:
> OK, I see the double patch in the notebook patch...I'll fix it. I've
also opened an issue on git, but I don't think that is what you meant by a
pull request. Do I need to make a branch?
These are the steps you can follow:
1. If you don't have a fork of the [https://github.com/sagemath/sagenb
sagemath/sagenb] github, then go to this page and click on "fork" on the
top right. This will create a fork of this git repository inside your
account.
2. In your own machine, clone your fork using
{{{
git clone git://github.com/<your username>/sagenb sagenb-github
}}}
In particular, you can follow [https://groups.google.com/d/msg/sage-
notebook/J9OHFqY2ufQ/gPijLnwyaOcJ the directions here] if you don't have a
git repo.
3. Next, make the changes to the files you want (for instance you may
apply your patch manually) and then commit your changes using
{{{
git add <filenames> # In case you have introduced new files
git commit -a -m "commit message"
}}}
4. Then push your changes to your own github repo using
{{{
git push -u origin
}}}
5. Finally go to your github page and click on "Pull Request" on the top.
This will create the pull request to sagemath/sagenb repository.
You can commit and push changes to the github page and the pull request
will be updated automatically with your new changes. Because of this
feature you can also decide to create a separate git branch and put a pull
request only from that branch, so that other changes that you are working
on don't get affected or included in the pull request.
If you are unclear about anything, just ask. I, kini, ohanar, are
available on #sagemath too and will be glad to help. If you already know
how to use git and github, then sorry for wasting your time. :)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12299#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
