#12299: Advance Jmol Interactive Features in Flask Notebook
-------------------------------------------------------+--------------------
Reporter: gutow | Owner: jason,
mpatel, was
Type: enhancement | Status:
needs_work
Priority: major | Milestone:
sage-5.2
Component: notebook | Resolution:
Keywords: Jmol, 3D, notebook | Work issues: decide
default display quality
Report Upstream: Reported upstream. No feedback yet. | Reviewers:
Karl-Dieter Crisman, Steven Trogdon
Authors: Jonathan Gutow | Merged in:
Dependencies: #11080,#11078,#11503 | Stopgaps:
-------------------------------------------------------+--------------------
Comment (by kcrisman):
Followups now that I've had time to think.
* Somehow the 'needs work' was not fixed, sorry.
* Responding to
> Did you at least get the warning that things were not likely to work?
It should have read something like: "Many of the advanced 3-D viewing
functions DO NOT work in Internet Explorer..." Or are things failing
before then?
You're right, it's failing before that.
* We do need the final doctests - can be very skimpy.
* Jonathan, I'm wondering whether it's worth creating a new error class
for this one specific error of not having the JVM. I mean, your string is
so informative, you could just raise a very generic error with that
message. Also, it would eliminate two needed doctests :)
* As for the upstream pull, you would only create one for the notebook,
that's right, and that could be merged upstream at the same time. I've
asked about the process for that there, in case there is anything weird.
This is looking really close to ready, though.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12299#comment:59>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
