#11080: move notebook to flask/wsgi-based notebook
---------------------------------------------------------------------------------------+
Reporter: jason
| Owner:
Type: enhancement
| Status: needs_review
Priority: blocker
| Milestone: sage-5.2
Component: notebook
| Resolution:
Keywords: sd31 sd35.5
| Work issues:
Report Upstream: N/A
| Reviewers: Rado Kirov, Dan Drake, Jason Grout, Simon King,
Dmitrii Pasechnik, John Palmieri, Punarbasu Purkayastha
Authors: Mike Hansen, Rado Kirov, William Stein, Jason Grout, Jeroen
Demeyer | Merged in:
Dependencies: #13126, #11078, #11874, #12229, #11503, #12327, #12899
| Stopgaps:
---------------------------------------------------------------------------------------+
Changes (by {'newvalue': u'Mike Hansen, Rado Kirov, William Stein, Jason Grout,
Jeroen Demeyer', 'oldvalue': u'Mike Hansen, Rado Kirov, William Stein, Jason
Grout'}):
* reviewer: Rado Kirov, Dan Drake, Jason Grout, Simon King, Dmitrii
Pasechnik => Rado Kirov, Dan Drake, Jason
Grout, Simon King, Dmitrii Pasechnik, John
Palmieri, Punarbasu Purkayastha
* author: Mike Hansen, Rado Kirov, William Stein, Jason Grout => Mike
Hansen, Rado Kirov, William Stein, Jason Grout,
Jeroen Demeyer
Comment:
Since jdemeyer said:
> On hawk, adding the compiler flag -D_XOPEN_SOURCE=500 fixes the problem.
> Normally such things should be added to $CPPFLAGS, not $CFLAGS.
so the two changes are from him, and jhpalmieri said:
> This seems to allow compilation on hawk and on mark, and compilation
still works on OS X Lion and sage.math.
so the review of that is from him, I don't quite understand why that isn't
enough for positive review. I assume that the CPPFLAGS version was also
actually tested, correct?
The current version of the spkg has this in it, so this sounds good
enough.
Of course there is this in the SPKG.txt, and presumably other misleading
stuff. Does it matter?
{{{
== Changelog ==
* For an accurate log of changes, run "hg log" in src/sagenb.
}}}
> I wonder if we'll reach 300 comments before this ticket is merged...
I guess so, Jason :)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11080#comment:328>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
