#13192: some code clean up for sage/graphs/graph.py
----------------------------------+-----------------------------------------
Reporter: eisermbi | Owner: jason, ncohen, rlm
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.2
Component: graph theory | Resolution:
Keywords: sparse6_string | Work issues:
Report Upstream: N/A | Reviewers: Nathann Cohen, Karl-Dieter
Crisman
Authors: Birk Eisermann | Merged in:
Dependencies: #13109 | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by kcrisman):
Sorry, I wasn't meaning to be too picky. I was just trying to avoid
craziness. I thought maybe your error in doctests was due to the
`doctest:1:`, so that is why I harped on it, same with the whitespace,
since it seemed to be in an unrelated place.
Anyway, my main point with the testing wasn't to show that it was the same
as before (though at least one non-trivial example would be nice), but
rather to test the thing ''you yourself'' (I though it was Nathann) first
noted in the description :-)
{{{
it works only on graphs whose vertices can be compared with the <
operator, e.g. integers
}}}
So I figured that at least one graph that was not properly
representable/represented/could have been bad in the `sparse_6string`
format before should be shown to operate properly now. And that should be
in the `sparse_6string` documentation.
I don't think you need to include a million examples in the other doctest,
though. My concern was that whatever the sorting was ''for'' in normal
graphs needed to be tested, and perhaps that is already done elsewhere.
I'm not familiar enough with that format to know why they have to be
sorted that way. Besides, once the function was removed, the tests in the
deprecated function would disappear anyway.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13192#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
